Support regional ofs models #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e included, even ones without regular grids.
|
@giumas please note that all Regional OFS models are able to be queried. Ones that do not have regular grids return url fetch errors currently. |
giumas
reviewed
Apr 25, 2019
| logging.basicConfig(level=logging.DEBUG, | ||
| format="%(levelname)-9s %(name)s.%(funcName)s:%(lineno)d > %(message)s") | ||
| logger = logging.getLogger(__name__) | ||
|
|
||
| switch = "LEOFS" # WOA09 or WOA13 or RTOFS or GoMOFS or LEOFS or LHOFS | ||
| # Choose Model | ||
| switch = 21 # Choose a ModelOptions Value to test |
There was a problem hiding this comment.
The hard-coding of an integer is not the intent of having an enumeration. Use ModelOptions.TBOFS!
| if switch == "WOA09": | ||
| model = ModelOptions | ||
|
|
||
| if switch == model.WOA09.value: |
There was a problem hiding this comment.
This should be: switch is ModelOption.WOA09
| ] | ||
|
|
||
| if switch == "WOA09": | ||
| model = ModelOptions |
| @@ -10,26 +10,76 @@ | |||
| from hyo2.soundspeedmanager.qt_callbacks import QtCallbacks | |||
|
|
|||
|
|
|||
| class ModelOptions(IntEnum): | |||
There was a problem hiding this comment.
Why are you duplicating this enumeration? You should just import and use the one in regofs.py.
| @@ -153,6 +161,11 @@ def query(self, lat: Optional[float], lon: Optional[float], datestamp: Union[dat | |||
| logger.critical("while converting location to grid coords, %s" % e) | |||
| return None | |||
|
|
|||
| ocean_time = self._file.variables['ocean_time'] | |||
| datetime_retrieved = num2date(ocean_time[0], units=ocean_time.units, calendar=ocean_time.calendar) | |||
| logger.debug(('Query datetime:\t\t\t%s' % original_datestamp.isoformat())) | |||
There was a problem hiding this comment.
There are better ways to align text than using tabs!
This was referenced Apr 28, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pull request addressing issue #23 points 1 and 2