Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geospatial operations for hydrological analysis #60

Closed
1 task done
sebastienlanglois opened this issue Dec 19, 2023 · 0 comments · Fixed by #61
Closed
1 task done

Geospatial operations for hydrological analysis #60

sebastienlanglois opened this issue Dec 19, 2023 · 0 comments · Fixed by #61
Assignees
@sebastienlanglois
Labels
enhancement New feature or request

Comments

@sebastienlanglois
Copy link
Contributor

sebastienlanglois commented Dec 19, 2023 •
edited
Loading

Addressing a Problem?

Hydrology uses geospatial operations, encompassing tasks such as watershed delineation and extraction of physiographic variables at the watershed scale. PAVICS-Hydro has implemented various functionalities in ravenpy to execute these operations.

It would be interesting to integrate some of these features into xhydro by leveraging the work done in ravenpy while also adding some new functionalities.

Potential Solution

The solution would include the functionalities included in ravenpy plus the followings :
Watershed Delineation

  1. Support concurrent delineation of multiple watersheds simultaneously.
  2. Enable access to official watershed polygons (shapefiles/geojson/geoparquet) from authoritative sources (DEH, HYDAT, USGS, HQ, etc.) —implemented collaboratively with xdatasets.

Physiographic Variable (or others) Extraction

  1. Support simultaneous extraction of physiographic variables across multiple watersheds.
  2. Facilitate the extraction of variables present in STAC catalogs (e.g., Planetary Computer).
  3. Accommodate cases where users employ their own rasters for extraction.
  4. Implement extraction considering pixel weighting rather than an "all_touched" approach, as this can significantly impact final results —implemented collaboratively with xdatasets.

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.
@sebastienlanglois sebastienlanglois added the enhancement New feature or request label Dec 19, 2023
@sebastienlanglois sebastienlanglois self-assigned this Dec 19, 2023
@sebastienlanglois sebastienlanglois mentioned this issue Dec 19, 2023
Merged
10 tasks
sebastienlanglois added a commit that referenced this issue Mar 12, 2024
@sebastienlanglois
Adding first gis module to perform geospatial operations, notebook bu…
376684f 
…ilds (#61)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #60 
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [X] (If applicable) Tests have been added.
- [X] CHANGES.rst has been updated (with summary of main changes).
- [X] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?
This PR adds a GIS module for usual geospatial operations that are
common in hydrology such a watershed delineation, watershed properties
extraction, etc. It adapts the work that's been done in
[ravenpy](https://ravenpy.readthedocs.io/) while also adding some new
functionalities.

**Watershed Delineation**

- [x] Support concurrent delineation of multiple watersheds
simultaneously.
- [X] Enable access to official watershed polygons
(shapefiles/geojson/geoparquet) from authoritative sources (DEH, HYDAT,
USGS, HQ, etc.) —implemented collaboratively with xdatasets.

**Physiographic Variable (or others) Extraction**

- [x] Support simultaneous extraction of physiographic variables across
multiple watersheds.
- [X] Facilitate the extraction of variables present in STAC catalogs
(e.g., Planetary Computer).
- [X] Implement extraction considering pixel weighting rather than an
"all_touched" approach, as this can significantly impact final results
—implemented collaboratively with xdatasets.

### Does this PR introduce a breaking change?
No

### Other information:
This PR also integrates the changes from #65 and #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastienlanglois sebastienlanglois

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding first gis module to perform geospatial operations, notebook builds hydrologie/xhydro
1 participant
@sebastienlanglois