Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in pytest version #111

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fix typo in pytest version #111

merged 2 commits into from
Mar 6, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Mar 6, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Fixes a typo in the pytest version that currently makes the tests fail.

Does this PR introduce a breaking change?

Other information:

@RondeauG RondeauG requested a review from Zeitsperre March 6, 2024 15:54
Zeitsperre
Zeitsperre requested changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my bad. We should be pinning for >=7.3.1.

RondeauG
RondeauG commented Mar 6, 2024
View reviewed changes
environment-dev.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@RondeauG RondeauG merged commit afc33e9 into main Mar 6, 2024
18 checks passed
@RondeauG RondeauG deleted the fix-pytest branch March 6, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RondeauG @Zeitsperre