Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optimal_interpolation notebook #123

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Added optimal_interpolation notebook #123

merged 3 commits into from
Mar 22, 2024

Conversation

richardarsenault
Copy link
Contributor

[X] (If applicable) Documentation has been added / updated (for bug fixes / features).

What kind of change does this PR introduce?

This PR adds a Notebook for testing the optimal interpolation, with a complete simple example to understand how the system works along with a fully working example and analysis for real-world data (using DEH data).

Does this PR introduce a breaking change?

No, but I did have to update the code at one place to provide a better output file for easier analysis.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the notebooks Run tests against notebooks label Mar 22, 2024
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Approved for additional tests label Mar 22, 2024
@richardarsenault richardarsenault merged commit 645a0d5 into main Mar 22, 2024
23 checks passed
@richardarsenault richardarsenault deleted the oi_notebook branch March 22, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests notebooks Run tests against notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants