Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #145

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix tests #145

merged 2 commits into from
May 14, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented May 14, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Tests for the GIS module were too strict.
  • Changes were made in xclim v0.49.0 with how the gamma and fisk distributions were initiated in xclim, which changed the fitting results and parametric quantiles. It just so happened that we arbitrarily used the gamma for our tests. To be backwards-compatible, those tests were changed to the gumbel_r.

Does this PR introduce a breaking change?

  • No.

Other information:

Changes to the gamma distribution:
Ouranosinc/xclim#1477
Ouranosinc/xclim#1720

Zeitsperre
Zeitsperre approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stats aren't my strongest suit, but LGTM

@github-actions github-actions bot added the approved Approved for additional tests label May 14, 2024
@RondeauG RondeauG merged commit 92c2b6d into main May 14, 2024
36 checks passed
@RondeauG RondeauG deleted the fixtests branch May 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

@sebastienlanglois sebastienlanglois Awaiting requested review from sebastienlanglois

@TC-FF TC-FF Awaiting requested review from TC-FF

Assignees
No one assigned
Labels
approved Approved for additional tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RondeauG @Zeitsperre