Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elevation and slope properties #151

Merged
merged 18 commits into from
Jun 10, 2024
Merged

add elevation and slope properties #151

merged 18 commits into from
Jun 10, 2024

Conversation

sebastienlanglois
Copy link
Contributor

@sebastienlanglois sebastienlanglois commented Jun 3, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)

  • (If applicable) Documentation has been added / updated (for bug fixes / features).

  • (If applicable) Tests have been added.

  • CHANGELOG.rst has been updated (with summary of main changes).

    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • This PR adds functions in the GIS module to extract elevation, slope and aspect ratio from a set of basins.
  • This also fixes a small bug (of lack of feature) in the current GIS module that limited the land use classification to the bounding box of a watershed rather than its boundaries.

Does this PR introduce a breaking change?

No

Other information:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the notebooks Run tests against notebooks label Jun 3, 2024
@sebastienlanglois sebastienlanglois marked this pull request as ready for review June 4, 2024 03:13
@sebastienlanglois sebastienlanglois self-assigned this Jun 4, 2024
Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the approved Approved for additional tests label Jun 6, 2024
@sebastienlanglois
Copy link
Contributor Author

Tests are failing maybe because of Planetary Computer's breaking changes on June 6th. It's probably a quick fix if someone needs this PR quickly or else, I will be back at work in 2 weeks to fix it before merging.

@Zeitsperre
Copy link
Collaborator

@sebastienlanglois

They changed a URL and our security hardening failed the builds as a result. I'll go about unblocking them.

@github-actions github-actions bot added the CI label Jun 10, 2024
@RondeauG RondeauG merged commit 3edfe44 into main Jun 10, 2024
20 checks passed
@RondeauG RondeauG deleted the altitude-slope-gis branch June 10, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI notebooks Run tests against notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants