-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xscen functions and move to conda environment #21
Conversation
# Conflicts: # environment.yml # setup.py
The failures are due to a packaging issue with xESMF. Let me see if I can find the discussion... |
If that's fine with you, I'd wait for #27 before adding an example in a Notebook, since we'll be able to leverage the one that has been started there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Not thrilled that we can't have a pure PyPI install at the moment, but that can come later from the xscen side.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
xscen
functions toxhydro
, mainly related to the computation of indicators and hydroclimatic statistics.Does this PR introduce a breaking change?
xhydro.py
. I don't think that we'll ever need this file, but it can be readded later.Other information: