Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xscen functions and move to conda environment #21

Merged
merged 27 commits into from
Sep 20, 2023
Merged

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Aug 30, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Adds a few xscen functions to xhydro, mainly related to the computation of indicators and hydroclimatic statistics.

Does this PR introduce a breaking change?

  • Deleted xhydro.py. I don't think that we'll ever need this file, but it can be readded later.

Other information:

environment.yml Outdated Show resolved Hide resolved
@Zeitsperre
Copy link
Collaborator

The failures are due to a packaging issue with xESMF. Let me see if I can find the discussion...

@RondeauG RondeauG changed the title Add xscen functions Add xscen functions and move to conda environment Sep 19, 2023
@RondeauG
Copy link
Collaborator Author

RondeauG commented Sep 19, 2023

If that's fine with you, I'd wait for #27 before adding an example in a Notebook, since we'll be able to leverage the one that has been started there.

xhydro/cc.py Outdated Show resolved Hide resolved
@RondeauG RondeauG requested a review from TC-FF September 20, 2023 13:32
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Not thrilled that we can't have a pure PyPI install at the moment, but that can come later from the xscen side.

@RondeauG RondeauG merged commit 9fd82fd into main Sep 20, 2023
11 checks passed
@RondeauG RondeauG deleted the indicators branch September 20, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importations xscen
2 participants