Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perturbed indicators #54

Merged
merged 17 commits into from
Feb 29, 2024
Merged

Perturbed indicators #54

merged 17 commits into from
Feb 29, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Dec 7, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • No.
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGES.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Indicateurs futurs utilisant la technique de pige aléatoire développée pour l'Atlas.

Does this PR introduce a breaking change?

  • La transition vers pandas>=2.2 signifie que certaines fréquences comme AS-JAN ou AS-DEC sont maintenant YS-JAN/YS-DEC.

Other information:

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@RondeauG RondeauG marked this pull request as ready for review January 18, 2024 21:29
@RondeauG
Copy link
Collaborator Author

@c-malenfant Sans nécessairement que tu fasses un review, je crois que cette PR pourrait t'intéresser. Tu peux aussi aller voir le notebook associé: https://xhydro--54.org.readthedocs.build/en/54/notebooks/climate_change.html

Copy link
Collaborator

@c-malenfant c-malenfant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Juste une coquille à vérifier dans le notebook, svp.

docs/notebooks/climate_change.ipynb Show resolved Hide resolved
docs/notebooks/climate_change.ipynb Show resolved Hide resolved
docs/notebooks/climate_change.ipynb Show resolved Hide resolved
docs/notebooks/climate_change.ipynb Show resolved Hide resolved
docs/notebooks/climate_change.ipynb Show resolved Hide resolved
docs/notebooks/climate_change.ipynb Show resolved Hide resolved
@RondeauG
Copy link
Collaborator Author

RondeauG commented Feb 22, 2024

xscen >=0.8.0 ne semble pas compatible avec python 3.12, mais on est en train de regarder ça: Ouranosinc/xscen#351

Edit: En fait, c'est plutôt que xclim <=0.47 n'a pas de build pour python 3.12 parce que trop de choses brisaient. La solution la plus clean est d'attendre la PR citée ci-dessus, puis de faire un release xscen 0.8.3 qui requiert xclim 0.48. Ça, ou on désactive temporairement les tests pour 3.12.

@Zeitsperre
Copy link
Collaborator

The latest version of xclim (v0.48.2) is now compatible with the upcoming version of xscen (v0.8.3). This version will be fully compatible with Python3.12.

@github-actions github-actions bot added the CI label Feb 29, 2024
@RondeauG RondeauG merged commit a2d9372 into main Feb 29, 2024
19 checks passed
@RondeauG RondeauG deleted the perturbinds branch February 29, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants