-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments and Ratings #186
Comments
First phase of implementation for this issue is pushed to github and a pull request has been created to merge it into develop. The following items have been implemented/fixed:
The following items are not yet working/implemented and need further investigation:
Suggest all items above to go into second phase into release 1.5 after the next immediate release 1.4. |
We want +1. We do not want a 1-10 scale. |
OK. Will revert it to +1 then. |
Have reverted it back to +1. Also added functionality for email notifications. In summary, only comment deletion by commenter and email notification customization in user profile are yet to be implemented. Others have been implemented for the first phase with further improvements to be done in the second phase when needed. See updated list above for details regarding what have been implemented and what needs further investigation. |
Further fixed email notification to ensure the email is sent to the resource owners, and if a comment is for another comment, the email is also sent to the original commenter this comment replies to. Also fixed a couple of formatting and styling issues so the nesting comment hierarchy should be displayed on resource landing page. The fix has been pushed to github with a pull request created to merge into develop and deploy to dev or alpha. |
Tested and works well enough to close. Commenter ability to delete their comments to be made a separate issue. |
Simplify the comments and ratings part of the resource landing page. See resource details mockup in Alfresco release 1 mockups from 10 months ago. This was developed by @horsburgh. Comments should be identified by the first and last name of the person who made them followed by the comment. The commenter has to be a hydroshare user so the functionality to add a comment should only appear if the user is a hydroshare user. The commenter name should be a link to the users profile. There should also be the ability to +1 a comment and +1 the resource itself. To +1 you also have to be a hydroshare user. The commenting system should not require a user to enter their name, username or URL as these should be part of the user profile. The only thing to fill in should be the text box that holds the comment.
Some additional rules I suggest
The first implementation does not need to implement email notifications, however any data structures established should not preclude this.
Assigned to @hyi for initial implementation, to @ironfroggy for comment as to good web practices and @horsburgh for suggestions on layout related to the original mockups and formatting of resource landing pages
The text was updated successfully, but these errors were encountered: