Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need file validation for pre_add_files_to_resource signal function #237

Closed
gantian127 opened this issue Mar 17, 2015 · 2 comments
Closed

Need file validation for pre_add_files_to_resource signal function #237

gantian127 opened this issue Mar 17, 2015 · 2 comments
Assignees
@gantian127
Milestone
Release 1.5.0

Comments

@gantian127
Copy link
Member

This is needed for netCDF resource. When a new file is added for the netCDF resource, the netcdf_pre_add_files_to_resource receiver function is running. So there is a need to check if the netCDF file stores valid netCDF data (This is for the condition that when a file is in "XXX.nc" format but is not real netCDF data set).
gantian127 pushed a commit that referenced this issue Mar 17, 2015
[#237] file validation for pre_add_files_to_resource : initial implem…
d4e336e 
…entation
mjstealey added a commit that referenced this issue Mar 17, 2015
@mjstealey
Merge pull request #238 from hydroshare/237-file-validation-for-pre-a…
ba8159a 
…dd-files-to-resource-signal

[#237] file validation for pre_add_files_to_resource : initial implementation
@dtarb dtarb added this to the Release 1.5.0 milestone Apr 1, 2015
@gantian127 gantian127 reopened this Apr 1, 2015
@gantian127
Copy link
Member Author

This issue has been solved and merged back to the develop branch

@dtarb
Copy link
Member

dtarb commented Apr 20, 2015

@gantian127 based on your comment above I am closing. Reopen if you think this still needs work.

@dtarb dtarb closed this as completed Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gantian127 gantian127

Labels
None yet
Projects
None yet
Milestone
Release 1.5.0
Development

No branches or pull requests
2 participants
@dtarb @gantian127