[#3242] Move Create button to main navigation bar #3308

Maurier · 2019-04-05T19:02:36Z

This PR adds a "Create" menu to the navigation bar and combines Help and About into a menu as well.
The "Create" button has been removed from the top left of My Resources page. These changes effectively remove the Create Resource page (the code will be left in place in case of need to rollback).

These changes can be tested at: https://playground.hydroshare.org

Create menu

Notification

Since the resource creation process can take some time, a notification message has been added to indicate that the resource is being created.

Note: This work is also going to be implemented at https://help.hydroshare.org/ and both PRs should be deployed at the same time for consistency.

Pull Request Checklist:

Positive Test Case Written by Dev

Automated Testing

Sufficient User and Developer Documentation

Passing Jenkins Build

Peer Code review and approval

Positive Test Case

Access the site.
Interact with the navigation items and verify the links work as expected.

[#3242] Consolidate alert functionality

…to 3242-move-create-to-navigation-bar

Maurier · 2019-04-05T19:09:21Z

theme/static/js/custom.js

+    $("#hs-nav-bar .res-dropdown ul > li>  a").on("click", function () {
+        var formData = new FormData();
+
+        formData.append("csrfmiddlewaretoken", csrf_token);


@pkdash It would be good to get rid of these irods-related parameters from the backend if they are not needed in the requests anymore. I've added them here for now because without them the request doesn't go through.

We could add these defaults server side and resource-type default to composite. making it so you only have to pass the token. Actually with this new workflow, I think we could probably remove all of the irods parameters completely from the create method. @hyi Is there any reason we can't remove the irods paramaters from "/hsapi/_internal/create-resource/do/"?

@pkdash @Maurier @sblack-usu These iRODS-related parameters in the request are for files selected from iRODS file browser when creating a resource using files from iRODS user zone or other third party iRODS zone, so we cannot get rid of them.

@hyi - But with the new create resource workflow, these parameters will never be used.

@sblack-usu OK. That makes sense. Then we can remove those parameters, or at least add a default when retrieving those request data, such as this line: https://github.com/hydroshare/hydroshare/blob/develop/hs_core/views/__init__.py#L1221 @Maurier @pkdash

Maurier · 2019-04-05T19:11:55Z

theme/static/js/custom.js

-        }, timeout)
+// Alert Types: "error", "success", "info"
+// pass a duration value of -1 for persistent alerts
+function customAlert(alertTitle, alertMessage, alertType, duration) {


We had different methods implementing the same kind of alert functionality, so they have been consolidated into one method to avoid redundancy.

Maurier · 2019-04-05T19:22:36Z

@dtarb, @Lizabrazil, @dtarb These changes can be tested at https://playground.hydroshare.org. Please have a look when you get a chance and let me know if you have any suggestions.

dtarb · 2019-04-05T20:04:31Z

I like it. But a few tweaks.

The empty resource landing page should probably not say "Congratulations!" We need to revise the message.
Create Collection Fails
The CREATE menu item should probably be there even when not logged in for consistency of look and feel. Behavior should be the same as currently for MyResources, requiring login.
For HELP, I do not think we need a drop down. I think about is part of help. I do suggest, as noted in "Create" should be moved to the top navigation with a dropdown #3242 putting an about HydroShare in the footer.

Suggestion for revised message
"This is the landing page for the resource you just created. Add files in the content area below and enter metadata where needed. The following metadata is required for your resource to be published or made public" Then give the list.

horsburgh · 2019-04-06T15:16:08Z

@dtarb - we currently have separate "help" and "about" links in the navigation at the top. @Maurier has consolidated them into one - I think this is consistent with what we talked about on the phone. Are you suggesting we should get rid of the "About" page? The About page is linked on the Help page, so I guess we really don't need About in the main navigation.

dtarb · 2019-04-06T15:21:16Z

@horsburgh I am suggesting what I wrote in #3242.

horsburgh · 2019-04-06T15:27:47Z

OK - fair enough. There's two sets of instructions in #3242, so I can see where @Maurier might have missed that.

@Maurier - I agree with the tweaks suggested by @dtarb above.

Maurier · 2019-04-06T15:29:32Z

Got it, I'm working on it. I'll update the deployment with these changes sometime this weekend.

Lizabrazil · 2019-04-08T15:13:22Z

Just reiterate, we just discussed and all agree that:
3. The CREATE menu item should probably be there even when not logged in for consistency of look and feel. Behavior should be the same as currently for MyResources, requiring login
4. Putting About in the footer, I also agree.

…to 3242-move-create-to-navigation-bar

Maurier · 2019-04-11T17:24:21Z

@dtarb, @Lizabrazil - I have made the changes now. Please have another look.

sblack-usu · 2019-04-11T20:22:28Z

I've never touched the help codebase, but I wonder if it's even worth the trouble making the help pages mimic hydroshare. Why not just something like "Back to HydroShare" as a menu item at the top. You already can't see the user information in the top right corner of the help pages.

sblack-usu · 2019-04-11T20:24:13Z

I found myself clicking the create menu item, which closed the popup box that opened when I hovered over. Maybe make it so it does not close upon clicking the create button?

theme/static/js/custom.js

dtarb · 2019-04-11T21:00:01Z

I did some quick tests and it all seems to work as expected.

Maurier · 2019-04-11T22:09:10Z

I found myself clicking the create menu item, which closed the popup box that opened when I hovered over. Maybe make it so it does not close upon clicking the create button?

Mobile devices still need to be able to click, so we would need to find another approach. The only other way I can think of is disabling the hover and trigger the popup only on click.

Lizabrazil · 2019-04-12T12:12:33Z

The first time I went through clicking create and signing in, it went to My Resources and then very quickly loaded the empty resource landing page. I tested again on another browser and it only does it the first time, but i thought it was a little odd.

Lizabrazil · 2019-04-12T12:13:25Z

Just read Scotts comment about this, so maybe it is already being addressed. Otherwise, looks good. I'm not sure what best practices are for hover versus click on main menu items.

Lizabrazil · 2019-04-12T12:18:01Z

If we did ever want to be completely mobile first then yes we would need to require a click

ghost · 2019-04-22T17:51:00Z

This has merge conflicts

…to 3242-move-create-to-navigation-bar # Conflicts: # theme/static/js/generic-resource.js

Maurier · 2019-04-25T17:23:39Z

I have updated the behavior to match that of @dtarb's comment quoted below:

I suggest the following

Create menu item does not have triangle next to it. This is so that all menus look the same. This addresses point 3 above. I think it would also address 4 above in that without the triangle it would look OK where it is, though where these items are on the top menu is a lesser consideration for me.

When not logged in Create menu item does not have dropdown. It behaves the same as My Resources menu item. It takes you to login, then after login you are on My Resources page. This addresses the cumbersome reroute of 1 above.

When logged in clicking Create (positive click, not mouse over) results in the drop down appearing at which point a user selects resource type to create.

On the help pages, recognizing that help is a separate site, the behavior is the same as not logged in. Clicking on Create would log you in (or if already logged in) take you to the My Resources page which has an active Create menu. This is the least likable item in this suggestion, but short of spending a whole lot of work to integrate Help with HydroShare, I think it is workable. There are also other differences between help and HydroShare - see Login shown on all tabs but Help and About. #3271, that I do not feel are worth spending effort on.

As item 4 needs to be implemented on the help system, once agreed, it would need to be implemented in a different PR.

Note that changes need to be made on the help pages later on to match this work.

https://playground.hydroshare.org

Maurier · 2019-05-07T15:26:40Z

@sblack-usu, could you review this work? At this point we have decided to go with this implementation outlined by @dtarb in the list above.

Note that, before deploying this to www, changes to the footer need to be made through the admin interface to include a link to the About page (https://help.hydroshare.org/about-hydroshare/) and it needs to persist in the database from then on:

sblack-usu · 2019-05-07T15:47:18Z

theme/templates/pages/menus/dropdown.html

@@ -15,11 +93,9 @@
        <a href="https://www.hydroshare.org/apps/">Apps</a>
    </li>
    <li class="" id="dropdown-menu-https:--help.hydroshare.org">
-        <a href="http://help.hydroshare.org">HELP</a>
-    </li>
-    <li class="" id="dropdown-menu-https:--help.hydroshare.org-about-hydroshare-">


so a link to about is going away? Just making sure this is intentional

Correct. Here is the discussion behind this change: #3242 (comment)

sblack-usu

This looks great, the updates work very well. As for the help pages, I'm for removing the nav bar from the help pages and maybe just have a link back to hydroshare. Of course that is an ongoing conversation that should not hold this work back.

Maurier · 2019-05-07T15:57:23Z

This looks great, the updates work very well. As for the help pages, I'm for removing the nav bar from the help pages and maybe just have a link back to hydroshare. Of course that is an ongoing conversation that should not hold this work back.

Thanks for reviewing! I will try to make the corresponding changes to the help pages today, and if all goes well we can proceed to merge this and have this ready for this release.

I will also follow up with another ticket where we can address removing unused iRODS related parameters from the requests used in this work.

Maurier · 2019-05-09T18:01:26Z

A PR with follow up changes for the Help pages has been approved here: hydroshare/hs_pages#16

This work can now be merged.

Maurier added 7 commits March 25, 2019 17:50

[#3242] Initial layout

b440d24

[#3242] Set up ajax call and form data

1c53f52

[#3242] Consolidate alert functionality

[#3242] Show alert info while the resource is being created

7bb0021

[#3242] Remove Create button from My Resources page

23f5719

[#3242] Simplify alert message call

4742ebe

[#3242] Combine Help and About menu items

c5ed851

Merge branch 'develop' of https://github.com/hydroshare/hydroshare in…

b951ab8

…to 3242-move-create-to-navigation-bar

Maurier commented Apr 5, 2019

View reviewed changes

Maurier added 3 commits April 5, 2019 13:25

Hide Create menu for anonimous users

ac25570

Hide Create menu for anonimous users

ae9b07d

Dismiss previous alert after an error

032400e

Maurier added 4 commits April 9, 2019 07:11

Remove About link from navigation bar

1dbf12f

Merge branch 'develop' of https://github.com/hydroshare/hydroshare in…

b65ad85

…to 3242-move-create-to-navigation-bar

Redirect logic for anonymous users

54c5a2d

Formatting

d3b4998

Maurier added 2 commits April 11, 2019 11:33

Update resource creation message

98244a2

Add navigation type logic in handling resource creation

31e3162

sblack-usu reviewed Apr 11, 2019

View reviewed changes

theme/static/js/custom.js Outdated Show resolved Hide resolved

Maurier added 2 commits April 25, 2019 10:05

Merge branch 'develop' of https://github.com/hydroshare/hydroshare in…

feb89cf

…to 3242-move-create-to-navigation-bar # Conflicts: # theme/static/js/generic-resource.js

[#3242] Update hover and redirect behavior

ab5b4b9

dtarb mentioned this pull request May 6, 2019

"Create" should be moved to the top navigation with a dropdown #3242

Closed

sblack-usu reviewed May 7, 2019

View reviewed changes

sblack-usu approved these changes May 7, 2019

View reviewed changes

Maurier changed the title ~~[WIP][#3242] Move Create button to main navigation bar~~ [#3242] Move Create button to main navigation bar May 8, 2019

Maurier mentioned this pull request May 8, 2019

Navbar adjustments hydroshare/hs_pages#15

Closed

Maurier merged commit 91695d4 into develop May 9, 2019

Maurier deleted the 3242-move-create-to-navigation-bar branch May 17, 2019 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#3242] Move Create button to main navigation bar #3308

[#3242] Move Create button to main navigation bar #3308

Maurier commented Apr 5, 2019 •

edited

Maurier Apr 5, 2019 •

edited

sblack-usu Apr 11, 2019

hyi Apr 12, 2019

sblack-usu Apr 12, 2019

hyi Apr 12, 2019

Maurier Apr 5, 2019 •

edited

Maurier commented Apr 5, 2019

dtarb commented Apr 5, 2019

horsburgh commented Apr 6, 2019

dtarb commented Apr 6, 2019

horsburgh commented Apr 6, 2019

Maurier commented Apr 6, 2019

Lizabrazil commented Apr 8, 2019

Maurier commented Apr 11, 2019

sblack-usu commented Apr 11, 2019

sblack-usu commented Apr 11, 2019

dtarb commented Apr 11, 2019

Maurier commented Apr 11, 2019

Lizabrazil commented Apr 12, 2019

Lizabrazil commented Apr 12, 2019

Lizabrazil commented Apr 12, 2019

ghost commented Apr 22, 2019

Maurier commented Apr 25, 2019 •

edited

Maurier commented May 7, 2019 •

edited

sblack-usu May 7, 2019

Maurier May 7, 2019

sblack-usu left a comment

Maurier commented May 7, 2019

Maurier commented May 9, 2019 •

edited

[#3242] Move Create button to main navigation bar #3308

[#3242] Move Create button to main navigation bar #3308

Conversation

Maurier commented Apr 5, 2019 • edited

Create menu

Notification

Pull Request Checklist:

Positive Test Case

Maurier Apr 5, 2019 • edited

Choose a reason for hiding this comment

sblack-usu Apr 11, 2019

Choose a reason for hiding this comment

hyi Apr 12, 2019

Choose a reason for hiding this comment

sblack-usu Apr 12, 2019

Choose a reason for hiding this comment

hyi Apr 12, 2019

Choose a reason for hiding this comment

Maurier Apr 5, 2019 • edited

Choose a reason for hiding this comment

Maurier commented Apr 5, 2019

dtarb commented Apr 5, 2019

horsburgh commented Apr 6, 2019

dtarb commented Apr 6, 2019

horsburgh commented Apr 6, 2019

Maurier commented Apr 6, 2019

Lizabrazil commented Apr 8, 2019

Maurier commented Apr 11, 2019

sblack-usu commented Apr 11, 2019

sblack-usu commented Apr 11, 2019

dtarb commented Apr 11, 2019

Maurier commented Apr 11, 2019

Lizabrazil commented Apr 12, 2019

Lizabrazil commented Apr 12, 2019

Lizabrazil commented Apr 12, 2019

ghost commented Apr 22, 2019

Maurier commented Apr 25, 2019 • edited

Maurier commented May 7, 2019 • edited

sblack-usu May 7, 2019

Choose a reason for hiding this comment

Maurier May 7, 2019

Choose a reason for hiding this comment

sblack-usu left a comment

Choose a reason for hiding this comment

Maurier commented May 7, 2019

Maurier commented May 9, 2019 • edited

Maurier commented Apr 5, 2019 •

edited

Maurier Apr 5, 2019 •

edited

Maurier Apr 5, 2019 •

edited

Maurier commented Apr 25, 2019 •

edited

Maurier commented May 7, 2019 •

edited

Maurier commented May 9, 2019 •

edited