Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-click menus in dialogs do not work on macOS #858

Closed
roachcord3 opened this issue Apr 22, 2021 · 9 comments
Closed

Right-click menus in dialogs do not work on macOS #858

roachcord3 opened this issue Apr 22, 2021 · 9 comments
Labels
bug OS: Mac Mac related issues

Comments

@roachcord3
Copy link

roachcord3 commented Apr 22, 2021

Environment

Hydrus version: v436, v437 (also happened on v435 Big Sur-compatible version)
Platform: macOS
OS specifics: Catalina 10.15.7, Big Sur 11.3

What happens

Right click menus in dialogs do not work. You can't click any element in them. This only happens on the Big Sur-compatible versions of Hydrus; the "old" client v435 does not have this issue. This is a problem both on Catalina and on Big Sur.

Steps to reproduce

  1. Open a dialog, such as the Manage Tags dialog
  2. Right click something, such as one of the tags in the tag list in Manage Tags
  3. Try to select any item in the right-click menu. It will not work. The system will beep at you.

Desired outcome

They should work as they have previously.

Error message / Log file / Screenshots

Screenshots aren't really useful, it would just look like the right click menu.

@roachcord3 roachcord3 added the bug label Apr 22, 2021
@roachcord3 roachcord3 changed the title Right-click menu dropdowns in dialogs do not work on macOS Big Sur-compatible versions of Hydrus (at least when running on Catalina) Right-click menus in dialogs do not work on macOS Apr 29, 2021
@CuddleBear92 CuddleBear92 added the OS: Mac Mac related issues label Jul 14, 2021
@hydrusnetwork
Copy link
Owner

Thank you for this report. I am very sorry to be replying so late. I am sorry to say I do not have a Big Sur machine to test with myself.

Please try opening manage tags from the media viewer and right-clicking on a tag there.

When launched from the media viewer, manage tags is not 'modal' like normal dialogs and should allow interaction with the rest of the program. If a menu works when it is non-modal, then that suggests we have a problem with modality, but if the menu does not work there either, that suggests we have a problem with child windows overall.

@roachcord3
Copy link
Author

@hydrusnetwork Right click menus work on the Manage tags window when it's spawned from the media viewer. I can confirm that with the current version, it still does not work when the Manage tags window is spawned from the thumbnail list.

@hydrusnetwork
Copy link
Owner

@roachcord3 Thank you for very quick reply. Can you try two things for me? Can you check that using up/down arrow keys and enter does work to use the menus (so this is just a mouse problem), and can you try just resizing the dialog window very slightly to see if that suddenly 'unlocks' the menu?

@roachcord3
Copy link
Author

@hydrusnetwork I have been using the arrow keys and enter to navigate right-click menus ever since opening this issue. Resizing the dialog does not seem to have an effect on the right-click menu. I tried resizing both before and after creating the right-click menu. Same thing with moving the dialog too, but that just makes the right-click menu disappear.

@hydrusnetwork
Copy link
Owner

Thank you for your help. I am going to work on this a bit, but I am not totally sure what is going on. I may need to revisit it next week to try a proper solution.

@hydrusnetwork
Copy link
Owner

Hey, I wrote a dialog version of a menu that will now show in macOS if you open a menu inside a dialog. If you like, you can turn it off with a new checkbox under options->gui, but it should let you use menus again with your mouse. Thank you for your patience, and please let me know if you have any trouble with it.
Screenshot 2021-10-26 194706

@roachcord3
Copy link
Author

Will it be available in the next release?

@roachcord3
Copy link
Author

@hydrusnetwork I have been using this feature since the release yesterday. In my opinion, it is just trading one kind of inconvenience for another, because I can't navigate these menus with the keyboard. It's neither worse nor better, it's just a matter of which works better for the user in question. I hope there will be a holistic fix eventually.

@nonmaterialistically
Copy link

The debug menu prevents macOS users from seeing if some options are ticked or not. Here's an example from tag import options, side by side:

imageimage

The status of any option can be changed by double-clicking, but there's no visual indication of the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS: Mac Mac related issues
Projects
None yet
Development

No branches or pull requests

4 participants