Log Failed Videos #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the following: - The feature request from issue hydrusvideodeduplicator#15 is functional. The new CLI argument to specify the page name is --failed-videos-page. - Additionally, all phashing failures with video-specific information are now simultaneously logged to a .txt file for easier info collection (file stored in the same directory as the database files) - The --job-count parameter can now be set via environment variable - An additional comment has been added with a specific link for checking the status of 'unordered-generator' on joblib's GH
|
Thanks for the work. This is a very cool feature. I will take another look at this after the refactor, as discussed. I don't expect you to rewrite any of this afterwards due to refactor changes so I will see what I can do. |
|
Closing this out as you've got it in there! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the following:
--failed-videos-page, has been added to specify the page name. The page must already exist within the Hydrus client at the time the program is run, and it must be a file search page. If there is more than one page with the same name, one of the pages will be chosen pseudo-randomly. If no valid page can be found, it fails gracefully while allowing the program to continue.--job-countparameter can now be set via environment variable