Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remain author section kbar button size and Update header word break attr #105

Merged
merged 3 commits into from
Jul 23, 2022

Conversation

hyesungoh
Copy link
Owner

Description

  • append flex-grow: 1 at AuthorSection's kbar button to remain button size
  • append word-break: break-word attr at MainHeader and PostHeader to prevent overflow button wrapper

@hyesungoh hyesungoh added bug Something isn't working style Change design or request it labels Jul 23, 2022
@hyesungoh hyesungoh self-assigned this Jul 23, 2022
@vercel
Copy link

vercel bot commented Jul 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
comet-land-blog ✅ Ready (Inspect) Visit Preview Jul 23, 2022 at 7:40PM (UTC)
comet-land-resume ✅ Ready (Inspect) Visit Preview Jul 23, 2022 at 7:40PM (UTC)

@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #105 (e641190) into main (534ef2d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         104      104           
  Lines        2905     2906    +1     
  Branches      480      480           
=======================================
+ Hits         2651     2652    +1     
  Misses        254      254           
Impacted Files Coverage Δ
...log/src/components/AuthorSection/AuthorSection.tsx 100.00% <100.00%> (ø)
apps/blog/src/components/Header/MainHeader.tsx 100.00% <100.00%> (ø)
apps/blog/src/components/Header/PostHeader.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534ef2d...e641190. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 23, 2022



Test summary

24 0 0 0


Run details

Project blog
Status Passed
Commit de03725 ℹ️
Started Jul 23, 2022 7:42 PM
Ended Jul 23, 2022 7:43 PM
Duration 01:12 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Jul 23, 2022



Test summary

16 0 0 0


Run details

Project resume
Status Passed
Commit de03725 ℹ️
Started Jul 23, 2022 7:44 PM
Ended Jul 23, 2022 7:44 PM
Duration 00:20 💡
OS Linux Ubuntu - 20.04
Browser Chrome 103

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@hyesungoh hyesungoh merged commit 5a8a77c into main Jul 23, 2022
@hyesungoh hyesungoh deleted the design/overflow-at-author-section-and-header branch July 27, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working style Change design or request it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant