Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about function extract_late in AT.py #25

Open
mujn1461 opened this issue Aug 8, 2021 · 1 comment
Open

Question about function extract_late in AT.py #25

mujn1461 opened this issue Aug 8, 2021 · 1 comment

Comments

@mujn1461
Copy link

mujn1461 commented Aug 8, 2021

Hi, thank you for creating this repo! I'm a little confused about the code of extract_late.

In equation 2 of your paper, you obtain the weights wt-1 from cropping and averaging the spatial latent representation Ft-1 at time t-1. This spatial latent representation seems to be feature_s from line 226, and the cropping is achieved in lines 235-241. Then lines 242-252 implements equations 3 and 4 depending on if the frame t-1 is a fixation or not. In equation 4 you weigh the new weights wt on the spatial latent representation at Ft at time t, which makes a lot of sense, but in the code feat = get_weighted(chn_weight, feature_s) new chn_weight wt are still used to weigh the same feature_s at time t-1. Maybe I missed something? Thanks in advance for your help!

@hyf015
Copy link
Owner

hyf015 commented Dec 1, 2022

Hi, sorry that I just saw this. It has been a long time since I wrote this code, and I cannot remember the details now.
I believe I intended to write code corresponding to the equations in the paper. However, if you are confident about the understanding of this code snippet, it might be a bug.
I would appreciate it if you can double-check, or possibly propose a fix to this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants