Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant braces in import #851

Closed
gilch opened this issue Jul 25, 2015 · 4 comments
Closed

Remove redundant braces in import #851

gilch opened this issue Jul 25, 2015 · 4 comments

Comments

@gilch
Copy link
Member

gilch commented Jul 25, 2015

From this

(import [tests.resources [kwtest function-with-a-dash]]
        [os.path [exists isdir isfile]]
        [sys :as systest])

to this

(import tests.resources [kwtest function-with-a-dash]
        os.path [exists isdir isfile]
        sys :as systest)
@refi64
Copy link
Contributor

refi64 commented Jul 25, 2015

This, along with #850 and #852, is going to break a lot, including quite a bit of my own code (which is probably going to be affected more by #850).

I would really like something like #740 in before this happens.

@algernon algernon added this to the Grand Language Cleanup milestone Jul 25, 2015
@Foxboron
Copy link
Member

-1 from me on this. I really don't see a reason to remove these braces. Let and with, yes sure. But import could match Clojure's import without any problems

@algernon
Copy link
Member

I'd keep the current import syntax. The current one is closer to Clojure, and in my opinion, is more readable than without a set of braces. In case of let and while, the double braces are annoying, but we don't have that with import (sometimes at the end, yes, but that's not an issue in general).

So 👎 from me too.

@algernon
Copy link
Member

The consensus here (even when not counting my own) seems to be in favour of keeping the current syntax. I don't see a compelling reason for dropping the redundant braces, therefore I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants