-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename hy model types #2031
Rename hy model types #2031
Conversation
I'm against this because I'd rather skip right to |
Are you opposed to including the models in the You mentioned #1644 in #1992, but that suggests making the models accessible as |
Both. I want |
Fair enough |
9aff53d
to
1e1c1b1
Compare
I've changed it so that the hy models can only be accessed through |
Thanks. Could you take any changes that aren't part of the massive search-and-replaces, like the NEWS line, and put them in one or more commits separate from the search-and-replaces? |
docs/language/internals.rst
Outdated
``hy.models.HySequence`` is the abstract base class of "iterable" Hy | ||
models, such as HyExpression and HyList. | ||
``hy.models.Sequence`` is the abstract base class of "iterable" Hy | ||
models, such as hy.Expression and hy.List. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are still a few places in the docs that aren't scoped to hy.models
, possibly other locations as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I forgot to check everywhere, but that should be fixed now.
600e725
to
644f507
Compare
I think that should be everything. The commits are somewhat intertwined, but I've separated them out into logical sections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
Haven't touched tests or documentation yet.
Hy models must now be accessed through `hy.models`.
644f507
to
f6dbbc0
Compare
Closes #1644.
All hy models have
Hy
removed from their name, soHyString
->String
,HyList
->List
etc.Also,
hy.models
has been prepended to the repr of all the models.There are still objects which include
Hy
in their name, such as all the hy errors,HyASTCompiler
,HyREPL
and maybe some others. It would be nice to rename those as well, if everyone agrees.