Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "import os" in setup.py #2197

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Add "import os" in setup.py #2197

merged 1 commit into from
Jan 8, 2022

Conversation

Arkelis
Copy link
Contributor

@Arkelis Arkelis commented Jan 8, 2022

When adding hy as a git depedency with Poetry, it tries to read setup.py and crashes because os is not imported

@Kodiologist
Copy link
Member

Now I wonder why setup.py works in the first place. Doesn't pip install execute it? So shouldn't it throw NameError when it hits os? Man, Python package management is mysterious.

Anyway, this is a very small change and seems fine to me. Thanks for catching it.

@Kodiologist Kodiologist merged commit 9163ceb into hylang:master Jan 8, 2022
@Arkelis Arkelis deleted the patch-1 branch January 8, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants