Remove Keyword.__slots__
#2294
Remove Keyword.__slots__
#2294
Conversation
|
@Kodiologist, are you just merging your own PRs now? |
|
I don't understand the question. |
|
Who else reviewed and approved this? |
|
Nobody. Have you forgotten the merge policy? |
|
Did you even ask for a review from anyone else? How about the people involved in the issue it was supposed to close? |
|
No, in fact, I've never asked for a review except when it's absolutely required for a PR to be merged. |
|
Apparently, reviews aren't required at all, especially when one doesn't even feel the need to request them. |
|
Right, unless there's a veto or it's for a new release. |
|
Listen, I'm sorry if you felt snubbed by the fact that I didn't ask you for a review. Please be assured it's nothing to do with your personally and you're still allowed to review whatever PRs you want. An important reason not to expect reviews is that, very often, people aren't free to do them. The reason I made this policy in the first place (#1508) is that Hy never had have enough active reviewers to make the old two-reviews-for-everything policy practical. Then I lowered the interval from 2 weeks to 3 days on Allie's urging (#1964) because we were both tired of waiting around 2 weeks for PRs that were obviously never going to get more comments on them. |
Closes #1928.