Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docs In Github Actions for Github pages. #2485

Closed
wants to merge 10 commits into from

Conversation

thomasmatecki
Copy link

@thomasmatecki thomasmatecki commented Aug 7, 2023

@Kodiologist
Copy link
Member

Oh nice, where can I see the output?

@thomasmatecki
Copy link
Author

Here: https://thomasmatecki.github.io/hy/

I tried out a different theme. I can change back if this is something mergeable.

@Kodiologist
Copy link
Member

It looks like the inclusion of version information isn't working. See how it says "hy unknown documentation" at the top? We'll want to publish a render for the most recent stable version of Hy at least; ideally also a separate one for master.

@Kodiologist
Copy link
Member

It could be a good idea to not change the theme in this PR if only to better see what's changed from the move to GitHub Pages alone. You can always propose a theme change in another PR.

@Kodiologist
Copy link
Member

It looks like the inclusion of version information isn't working. See how it says "hy unknown documentation" at the top?

Any progress on fixing this?

@thomasmatecki
Copy link
Author

It looks like the inclusion of version information isn't working. See how it says "hy unknown documentation" at the top?

Any progress on fixing this?

Yes, I changed it back to the rtd theme, which seems to look fine: https://thomasmatecki.github.io/hy/

Spent some time noodling on if it's possible to have two versions of these deployed at once, for master and a latest stable, to no avail.

@Kodiologist
Copy link
Member

I'm afraid the version information still isn't set correctly. See how it says "Hy version unknown" at the top?

@thomasmatecki
Copy link
Author

I'm afraid the version information still isn't set correctly. See how it says "Hy version unknown" at the top?

Oh I see! No, I haven't had time to figure out what's going there.

@Kodiologist
Copy link
Member

I'm closing this PR for inactivity. Let me know when you want me to look at it again and I'll reopen it. Maybe I'll pick it myself at some point.

@Kodiologist Kodiologist closed this Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop using Read the Docs
2 participants