Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellany #2490

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Miscellany #2490

merged 4 commits into from
Aug 13, 2023

Conversation

Kodiologist
Copy link
Member

scauligi
scauligi approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@scauligi scauligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

scauligi
scauligi approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@scauligi scauligi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to actually submit my comment on this one. No objections here! wait what my previous comment wasn't showing for a bit, I was very confused

@Kodiologist
Copy link
Member Author

Kodiologist commented Aug 10, 2023 •
edited
Loading

I've force-pushed to tweak gensym a bit more. In particular, if mangling would be necessary, it does the mangling itself and then removes the _hyx_, so the result always starts with _hy_ as desired, even after mangling.

@Kodiologist
Small documentation improvements
c9796af
@Kodiologist
Simplify some gensym tests
9b162c5
@Kodiologist
Change the gensym format
ebc95dd 
The new format uses the `_hy_` prefix the we've already officially reserved for a while, and it doesn't need mangling.

Since I construe the gensym format as an internal matter, it remains undocumented.
@Kodiologist
Forbid ~@ #*
3206396
@Kodiologist Kodiologist merged commit f92e8a1 into hylang:master Aug 13, 2023
9 checks passed
@Kodiologist Kodiologist deleted the misc branch November 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scauligi scauligi scauligi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

~@ #* … produces a weird result instead of an error
2 participants
@Kodiologist @scauligi