Improve quasiquote testing and docs #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scauligi
approved these changes
Aug 13, 2023
|
In hindsight, |
to avoid crashes from names that look like malformed mangles.
Kodiologist
force-pushed
the
quasiquote
branch
from
09e07f5
to
8d433e8
Compare
|
I've opted to keep both, but I've renamed and reordered them a bit to make their similarities clearer. |
Kodiologist
force-pushed
the
quasiquote
branch
from
8d433e8
to
151f0a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of soul-searching and adding a few more tests, I've decided that the way Hy does quasiquotation is correct, or at least, correct enough.
I was pointed to a pretty thorough test suite of quasiquotation in Common Lisp, but translating it to Hy looks intimidating, so I'm not going to take that on before I'm convinced that we need even more tests than what I've added here.