-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First-class global macros #2511
Conversation
Hold on, I'm confused. Are we considering |
Right, it was internal, but by documenting it, I'm making it public. Making what we already have public seemed like a more straightforward way to provide these features than to add another interface.
It is, yes, but that seems more like something for Hyrule than something to keep as a core macro. |
I disagree wrt Otherwise, for other removals like |
Thing is, Hy's analog of Python's
It's the sort of thing one could add to Hyrule, but I have no motivation to do so. I don't see myself manipulating the macro system like this a huge amount. |
My preference is still to keep |
Okay, I'll take a stab at adding |
b924aa7
to
2b059e0
Compare
|
2b059e0
to
401e0e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, otherwise looks fine 👍
This pull request partly fulfills #1467, by testing and documenting introspection that's possible via
_hy_macros
, and removing some functions and macros that are made redundant by these features._hy_macros
only provides access to global macros, so the missing part is support for local macros. That I expect to require implementing new features, so I'm leaving it for another PR.