Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of nanJ etc. #2522

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix parsing of nanJ etc. #2522

merged 1 commit into from
Oct 20, 2023

Conversation

Kodiologist
Copy link
Member

Fixes #2521.

scauligi
scauligi approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@scauligi scauligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, that was fast. 🚀

@Kodiologist
Copy link
Member Author

In truth, I dislike that Python allows 3J for 3j, 1E2 for 1e2, and 0X10 for 0x10, but it's not worth trying to make Hy case-sensitive about these things.

@Kodiologist Kodiologist merged commit 5439354 into hylang:master Oct 20, 2023
9 checks passed
@Kodiologist Kodiologist deleted the imaginary-uppercase branch November 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scauligi scauligi scauligi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any capitalization of NaN and Inf are parsed as imaginary numbers with uppercase suffix J
2 participants
@Kodiologist @scauligi