Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async generators no longer implicitly return final expressions #2524

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Async generators no longer implicitly return final expressions #2524

merged 2 commits into from
Oct 31, 2023

Conversation

scauligi
Copy link
Member

Fixes #2523.

@Kodiologist
Copy link
Member

Nice! Maybe add a comment or two to the new attributes of ScopeFn describing their purpose. A reader would naturally assume that they have something to do with scope tracking, but they really don't.

@scauligi scauligi merged commit 47ab79f into hylang:master Oct 31, 2023
9 checks passed
@scauligi scauligi deleted the async_gen_expr branch October 31, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kodiologist Kodiologist Kodiologist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hy produces an illegal implicit return in async generators
2 participants
@scauligi @Kodiologist