Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set comprehensions, dict comprehensions and generator expressions #448

Merged
merged 1 commit into from Jan 16, 2014

Conversation

olasd
Copy link
Member

@olasd olasd commented Jan 15, 2014

Closes: #14 (woo, two-digit tickets)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.17%) when pulling 8bfa4f3 on olasd:feature/genexpr into da59b20 on hylang:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.35%) when pulling 8bfa4f3 on olasd:feature/genexpr into da59b20 on hylang:master.

@paultag
Copy link
Member

paultag commented Jan 16, 2014

Slick look. Nice refactor. Was going to suggest that if you didn't manage to do it (should have known)

Has ACK. Nice work.

@theanalyst
Copy link
Member

+1, very nice to have generator expressions & dict comprehensions

On Thu, Jan 16, 2014 at 8:21 AM, Paul Tagliamonte
notifications@github.comwrote:

Slick look. Nice refactor. Was going to suggest that if you didn't manage
to do it (should have known)

Has ACK. Nice work.


Reply to this email directly or view it on GitHubhttps://github.com//pull/448#issuecomment-32438133
.

@algernon
Copy link
Member

Looks sweet. 👍

@paultag
Copy link
Member

paultag commented Jan 16, 2014

Someone merge the damn thing :)
On Jan 16, 2014 5:45 AM, "Gergely Nagy" notifications@github.com wrote:

Looks sweet. [image: 👍]


Reply to this email directly or view it on GitHubhttps://github.com//pull/448#issuecomment-32458477
.

@Foxboron
Copy link
Member

👍 :shipit:

Foxboron added a commit that referenced this pull request Jan 16, 2014
Add set comprehensions, dict comprehensions and generator expressions
@Foxboron Foxboron merged commit d34c22e into hylang:master Jan 16, 2014
@theanalyst theanalyst mentioned this pull request Jan 22, 2014
@olasd olasd deleted the feature/genexpr branch April 28, 2014 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dict comprehension
6 participants