Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Hyrule 0.1 #19

Merged
merged 12 commits into from
Jan 9, 2022
Merged

Release Hyrule 0.1 #19

merged 12 commits into from
Jan 9, 2022

Conversation

Kodiologist
Copy link
Member

@Kodiologist Kodiologist commented Jan 3, 2022

Fixes #10.

I won't actually merge the last commit into master, so Hyrule master will continue to depend on Hy master instead of the latest alpha. Popped out into the following patch:

From 32ab8a15b7c0a257c42ee6b58e16c3f81553794b Mon Sep 17 00:00:00 2001
From: Kodi Arfer <x>
Date: Fri, 7 Jan 2022 16:30:21 -0500
Subject: [PATCH] Set versioning for release

---
 hyrule/__init__.py | 2 +-
 setup.py           | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hyrule/__init__.py b/hyrule/__init__.py
index f86dde2..6522be5 100644
--- a/hyrule/__init__.py
+++ b/hyrule/__init__.py
@@ -1,7 +1,7 @@
 # We use an `__init__.py` instead of `__init__.hy` so that importing
 # from Python works even if `hy` hasn't been imported yet.
 
-__version__ = 'unreleased'
+__version__ = '0.1'
 
 import hy
 hy.macros.require('hyrule.hy_init',
diff --git a/setup.py b/setup.py
index 6621c8d..9f264b3 100644
--- a/setup.py
+++ b/setup.py
@@ -7,9 +7,9 @@ with open('README.rst', 'r') as o:
 
 setuptools.setup(
     name = 'hyrule',
-    version = None,
+    version = '0.1',
     install_requires = [
-        'hy @ git+https://github.com/hylang/hy@master#egg=hy-1.0'],
+        'hy == 1.0a4'],
     extras_require = dict(
         docs = [
             'Sphinx == 3.5.4',
-- 
2.32.0

@Kodiologist
Copy link
Member Author

I was surprised at first that tests are failing, but they're failing because Hy 1.0a4 doesn't exist yet, of course.

@Kodiologist
Copy link
Member Author

@allison-casey Does this look like the right set of names to expose for pprint?

@allison-casey
Copy link
Contributor

I believe you missed pprint and saferepr

@Kodiologist
Copy link
Member Author

Thanks. Added.

@allison-casey
Copy link
Contributor

ifp isn't exposed in the documentation. I think i should probably be moved to hy.control and exposed there though. Otherwise looks good

@Kodiologist
Copy link
Member Author

Kodiologist commented Jan 6, 2022

Hasn't ifp always been an internal subroutine? I don't think it's terribly useful because it requires you to already have the predicate you need at hand or to write an explicit lambda. An anaphoric version would be better, or a macro case specifically for when the predicate is =, which would presumably be the most common case (pun not intended).

@Kodiologist
Copy link
Member Author

The "predicate" isn't really a predicate, anyway. It's a relation.

@allison-casey
Copy link
Contributor

allison-casey commented Jan 6, 2022

I don't believe it was intended to be internal. I think it was just put in destructure since hy.contrib was a bit of a mess and there wasn't a better place to put it when destructure was added. pred should be changed to something else yes, but i've found it pretty useful as an alternative for when you can't use 3.10's
match.

@Kodiologist
Copy link
Member Author

Aright, it's not like Hyrule 0.2 is supposed to be backwards-compatible, anyway. Done. I'll also make an issue to replace it.

@Kodiologist
Copy link
Member Author

@paultag? @scauligi?

Copy link
Member

@scauligi scauligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Kodiologist Kodiologist merged commit 552086d into hylang:master Jan 9, 2022
@Kodiologist
Copy link
Member Author

Oh dear. So everything's good and released now, except when I do twine upload dist/* to put Hyrule on PyPI, I get

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
Invalid value for requires_dist. Error: Can't have direct dependency: "sphinxcontrib-hydomain @ git+https://github.com/hylang/sphinxcontrib-hydomain@master#egg=sphinxcontrib-hydomain-1.0 ; extra == 'docs'"

It looks like PyPI forbids URLs as dependencies. I think this means sphinxcontrib-hydomain needs a new PyPI release. @allison-casey What say you?

@allison-casey
Copy link
Contributor

I would just remove the extra_deps key. we don't use it in hy and I don't see a reason to use it now. especially for a dep that is only used for development.

@Kodiologist
Copy link
Member Author

Aright, seems reasonable. I should put them in the README, if only so I can remember which version of Sphinx is required.

@allison-casey
Copy link
Contributor

Why not add a requirements_dev.txt? That's the usual idiom for this kind of thing

@Kodiologist
Copy link
Member Author

Oh, right. Good idea.

@Kodiologist
Copy link
Member Author

As a pleasant side-effect, Read the Docs is now building again, for the first time in 3 months (oops).

@Kodiologist
Copy link
Member Author

https://pypi.org/project/hyrule

Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal functions and macros appear in the generated documentation
3 participants