-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Hyrule 0.1 #19
Conversation
I was surprised at first that tests are failing, but they're failing because Hy 1.0a4 doesn't exist yet, of course. |
@allison-casey Does this look like the right set of names to expose for |
I believe you missed |
Thanks. Added. |
|
Hasn't |
The "predicate" isn't really a predicate, anyway. It's a relation. |
I don't believe it was intended to be internal. I think it was just put in |
We can't call the module just "pprint" because then `hyrule.pprint` would be ambiguous between the module name and the function name.
Aright, it's not like Hyrule 0.2 is supposed to be backwards-compatible, anyway. Done. I'll also make an issue to replace it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Oh dear. So everything's good and released now, except when I do
It looks like PyPI forbids URLs as dependencies. I think this means sphinxcontrib-hydomain needs a new PyPI release. @allison-casey What say you? |
I would just remove the |
Aright, seems reasonable. I should put them in the README, if only so I can remember which version of Sphinx is required. |
Why not add a |
Oh, right. Good idea. |
As a pleasant side-effect, Read the Docs is now building again, for the first time in 3 months (oops). |
https://pypi.org/project/hyrule Hooray! |
Fixes #10.
I won't actually merge the last commit into master, so Hyrule master will continue to depend on Hy master instead of the latest alpha.Popped out into the following patch: