This repository has been archived by the owner on Jan 3, 2019. It is now read-only.
Use HttpServerParser to do span name customization #51
Assignees
Labels
Comments
hyleung
added a commit
that referenced
this issue
Dec 13, 2017
This commit introduces an implementaton of HttpServerParser and refactors the server tracing handler such that span name customization is done via the HttpServerParser instead of directly in the tracing handler. In order to make this work, needed to add a wrapper around the standard Ratpack Response so that things like the PathBinding and original ServerRequest are available to the HttpServerParser. Closes #51
hyleung
added a commit
that referenced
this issue
Dec 15, 2017
This commit introduces an implementaton of HttpServerParser and refactors the server tracing handler such that span name customization is done via the HttpServerParser instead of directly in the tracing handler. In order to make this work, needed to add a wrapper around the standard Ratpack Response so that things like the PathBinding and original ServerRequest are available to the HttpServerParser. Closes #51
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current implementation in
DefaultServerTracingHandlercustomizes the span name by setting it directly into the Span. We should rework this implementation so that it uses Brave'sHttpServerParserto implement span naming (and tagging) policy - see https://github.com/openzipkin/brave/blob/master/instrumentation/http/README.md#span-data-policySee thread from #48 for additional context
The text was updated successfully, but these errors were encountered: