Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app freezes if no internet connection #12

Open
hymm opened this issue Aug 16, 2017 · 3 comments
Open

app freezes if no internet connection #12

hymm opened this issue Aug 16, 2017 · 3 comments
Labels

Comments

@hymm
Copy link
Owner

hymm commented Aug 16, 2017

No description provided.

@hymm
Copy link
Owner Author

hymm commented Aug 23, 2017

probably making all the calls from the renderer to the main process will fix this problem. i.e. replace the calls of sendSync with calls to just send and create a new handler. See changes done to stat.ink uploading in results.js and electron.js

@hymm hymm mentioned this issue Aug 28, 2017
59 tasks
@okuRaku
Copy link
Contributor

okuRaku commented Aug 30, 2017

Wish I could help with this one. I'm a js/react newb learning as I go while adding a new feature I wanted, but this is blocking me currently (I'm aggregating league rankings data and there are holes in it, urls that don't work). I'll check out stat.ink uploading code see if I can piece something together.

@hymm
Copy link
Owner Author

hymm commented Aug 30, 2017

basically what needs to be done is that getApi event instead of returning with e.returnValue it needs to send the value back with an event (channel) using something like e.send('apiData', value). Try making a new event handler for something like ipcMain.on('getApiAsync, ...) and use ipcRenderer.send in the renderer process.

it should be similar to what I did with ipcMain.on('writeToStatInk'... in public/main/index.js

@hymm hymm mentioned this issue Sep 8, 2017
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants