-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent advice for key derivation #118
Comments
Ideally you would cite the source you got the advice from |
The paper is outdated and the argon2.rst quote is technically true, but unfortunate so I will try to reword it. The actual recommendations are in https://argon2-cffi.readthedocs.io/en/stable/parameters.html that recommends 2id and cites the source too: RFC 9106. |
do you find 06a4a5b helpful? |
I have submitted a PR in phc-winner-argon2 to add a link to the RFC because the pdf gives outdated advice |
@hynek thanks for updating the docs, much better now! as you've seen, we'll use argon2-cffi in borgbackup, thanks for writing it! \o/ |
This tells me argon2i is the preferred type for password-based key derivation:
argon2-cffi/docs/argon2.rst
Lines 20 to 22 in a112416
This tells me argon2id is preferred:
argon2-cffi/src/argon2/low_level.py
Lines 57 to 65 in e9f84e4
The argon2 paper appears to recommend argon2i: (emphasis mine):
The text was updated successfully, but these errors were encountered: