Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document versioning: Argon2 version 1.3 (v=19) from 2017 #64

Closed
nealmcb opened this issue Jun 24, 2020 · 0 comments · Fixed by #65
Closed

Document versioning: Argon2 version 1.3 (v=19) from 2017 #64

nealmcb opened this issue Jun 24, 2020 · 0 comments · Fixed by #65

Comments

@nealmcb
Copy link
Contributor

nealmcb commented Jun 24, 2020

As discussed in Towards Practical Attacks on Argon2i and Balloon Hashing by Joel Alwen and Jeremiah Blocki, there have been significant changes to the version of Argon2 which won the Password Hashing Competition in 2015. The lastest version is 1.3, as described in the March 24, 2017 version of the Argon2 paper Argon2: the memory-hard function for password hashing and other applications by Alex Biryukov, Daniel Dinu, and Dmitry Khovratovich.

The current (2020) version of argon2-cffi implements version 1.3, as evidenced by the $v=19 (0x13) parameter in the produced hashes, but that is not documented anywhere in the repo that I've seen.

The README and the documentation should indicate which version is implemented, and document when it changes in the Changelog.

nealmcb added a commit to nealmcb/argon2-cffi that referenced this issue Jun 24, 2020
Fixes hynek#64 for the README.md
More detail on versioning in the Changelog would also be great.
@hynek hynek closed this as completed in #65 Jun 26, 2020
hynek pushed a commit that referenced this issue Jun 26, 2020
* Note - implements Argon2 version 1.3

Fixes #64 for the README.md
More detail on versioning in the Changelog would also be great.

* Fix lint bug trailing-whitespace

* Fix grammar

Three fixes in one :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant