Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt default params to RFC, add necessary hash agility #41

Merged
merged 3 commits into from
Aug 19, 2018
Merged

Adapt default params to RFC, add necessary hash agility #41

merged 3 commits into from
Aug 19, 2018

Conversation

hynek
Copy link
Owner

@hynek hynek commented Aug 12, 2018

Learn to parse and check parameters.

@hynek hynek mentioned this pull request Aug 12, 2018
Closed
@hynek
Copy link
Owner Author

hynek commented Aug 16, 2018

So um @lvh any chance you could have a glance? I believe this fixes #35 and #36 – two things you mentioned you’d like to see added. ❤️

lvh
lvh reviewed Aug 16, 2018
View reviewed changes
CHANGELOG.rst Show resolved Hide resolved
@lvh
Copy link

lvh commented Aug 16, 2018

Everything looks fine except the changelog entry.

lvh
lvh approved these changes Aug 17, 2018
View reviewed changes
Copy link

@lvh lvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@hynek hynek merged commit 1ec39f8 into master Aug 19, 2018
@hynek hynek deleted the extract-params branch August 19, 2018 03:49
@hynek
Copy link
Owner Author

hynek commented Aug 19, 2018

Thanks for taking the time! ❤️

@B-McDonnell B-McDonnell mentioned this pull request Sep 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvh lvh lvh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hynek @lvh