Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOC patching for pydoctor #133

Merged
merged 3 commits into from Oct 6, 2022
Merged

Fix TOC patching for pydoctor #133

merged 3 commits into from Oct 6, 2022

Conversation

hynek
Copy link
Owner

@hynek hynek commented Oct 6, 2022

@Kapeli can you verify this fixes #132 please?

@Kapeli
Copy link
Contributor

Kapeli commented Oct 6, 2022

No 😢. It adds the TOC anchors into the page's sidebar.

This seems to work:

or soup.find("a", {"name": anchor})

@hynek
Copy link
Owner Author

hynek commented Oct 6, 2022

Hmm that makes me a tiny bit nervous … how about or soup.find("a", {"name": name}) (as just pushed).

@Kapeli
Copy link
Contributor

Kapeli commented Oct 6, 2022

Works! ❤️

@hynek hynek merged commit a4ef4ff into main Oct 6, 2022
@hynek hynek deleted the fix-pydoctor-anchors branch October 6, 2022 13:14
@hynek
Copy link
Owner Author

hynek commented Oct 6, 2022

Awesome, thanks!

It might take a moment until 3.1, because I want to do #130, #129, and #128 (whatever that is) and releasing now is a PITA thanks to the brew tap and binaries. But you seem comfortable running it from main. 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't find anchors to patch TOC for pydoctor docs (Twisted)
2 participants