Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --parser option to specify import path #60

Merged
merged 9 commits into from
Jun 10, 2017

Conversation

jnothman
Copy link
Contributor

@jnothman jnothman commented Mar 8, 2017

A library can now create (or extend) a parser in a module of their choice such that doc2dash --parser mymodule.MyParser path will build with that parser, avoiding the need for autodetection strategies

@codecov
Copy link

codecov bot commented Mar 9, 2017

Codecov Report

Merging #60 into master will decrease coverage by -3.79%.
The diff coverage is 47.82%.

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage     100%   96.21%   -3.79%     
==========================================
  Files           7        7              
  Lines         299      317      +18     
  Branches       39       40       +1     
==========================================
+ Hits          299      305       +6     
- Misses          0       11      +11     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/doc2dash/main.py 91.17% <47.82%> (-8.83%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8ab76...ea8d72b. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 9, 2017

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #60   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         309    327   +18     
  Branches       40     42    +2     
=====================================
+ Hits          309    327   +18
Impacted Files Coverage Δ
src/doc2dash/__main__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83c66d...a06a51e. Read the comment docs.

@jnothman
Copy link
Contributor Author

jnothman commented Mar 9, 2017

Again flake8 is the only failure.

@hynek
Copy link
Owner

hynek commented Jun 3, 2017

This needs a changelog entry and a docs update (usage.rst). Thanks!

@hynek hynek merged commit d28cef5 into hynek:master Jun 10, 2017
@hynek
Copy link
Owner

hynek commented Jun 10, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants