Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sifting logic into separate function #20

Closed
mithrandi opened this issue Mar 17, 2016 · 2 comments
Closed

Split sifting logic into separate function #20

mithrandi opened this issue Mar 17, 2016 · 2 comments

Comments

@mithrandi
Copy link
Contributor

certificateOptionsFromPEMs actually does two things at the moment:

  1. Sifts a pile of PEM objects into key + cert + chain certs (and with Support loading DH parameters in pem.twisted.certificateOptionsFromFiles #18, dhparams).
  2. Turns those things into a CertificateOptions.

I'd kinda like to have 1 without 2, since CertificateOptions has OpenSSL.crypto.x509 objects instead of cryptography.x509 objects, the latter having a much more useful API. @hynek do you think it's sensible to split these up?

@hynek
Copy link
Owner

hynek commented Mar 17, 2016

Yes, because pyOpenSSL will hopefully move to cryptography.x509 too pyca/pyopenssl#439 .

I’m also idling thinking about supporting stdlib by writing those files into temporary files and load them from there.

@mithrandi
Copy link
Contributor Author

Gah. This can't work exactly as stated, because there's no way to know which cert goes with the private key until you've loaded them with something that can give you the public key...

@hynek hynek closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants