Finish deprecation of functions in __init__ #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deprecation interval is 1 year. But yeah, I completely fucked this up. You could fix it by moving the imports into the compatibility functions I think? |
Importing from twisted in __init__ means twisted and pyopenssl are required dependencies for core as well. Fix the imports for these to remove the depencency on twisted and pyopenssl.
|
Does this look better? |
|
No, I’m sorry but that’s not what I had in mind. Before I keep you busy with my confusing pipe dreams, I had a shot myself. Can you confirm that d097f44 fixed your problem? |
|
Yeah, it appears to have fixed it. No worries, just wanted it to work, and now it does! Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing from twisted in init means twisted and pyopenssl are
required dependencies for core as well. Finish removing these methods to
remove the depencency on twisted and pyopenssl.
Removing deprecated functions: