-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release (20.2) has a typing issue #290
Comments
Aw crap, does wrap_dict return the wrong type? Gotta expand typing-examples I guess 😒. Meanwhile, may I recommend stopping to use wrap_dict and look into the new threadlocal primitives that allow to separate what you keep in threadlocal and what not? I think they're highly superior! |
Fixed and used your example as a regression test in the typing example. Happy new year to you too! |
When do you plan to release this fix @hynek ? |
I'm sorry, but that doesn't warrant an emergency release…just add a |
My CI fails for a new
structlog
release: https://github.com/wemake-services/wemake-django-template/pull/1418/checks?check_run_id=1632259635#step:7:861Here's what happens:
Here's the source code which works correctly with
20.1
: https://github.com/wemake-services/wemake-django-template/blob/master/%7B%7Bcookiecutter.project_name%7D%7D/server/settings/components/logging.py#L73P.S. Happy New Year! 🎄
The text was updated successfully, but these errors were encountered: