-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22.2.0 - TypeError with logger.exception and string interpolation #473
Comments
Hello @alangenfeld I confirm the bug. It happens here too. Our bitbucket pipelines kepts hanging for hours. Today bitbucket pipeline service was actually down. So I thought to wait the fix. But next still had the problem. It boiled down to this specific error. I rolled back to a previous version and the pipeline passed. Because we used the logger extensively our pipeline just bursted I guess. They hanged 2 hours and then crash. I guess the stack trace was huge :-) I unfortunately cannot share more specific code but can confirm that the error was basically screwing up our testing suite. Cheers |
I would've been helpful if either of you gave an Short, Self Contained, Correct, Example or at least a call example. Please help me understand this here, so far I'm guessing:
? So far it looks like a case of Hyrum's Law to me – the
@alangenfeld are you aware that if you're in an except block, you don't have to pass the exception into I'm not sure what to do here there seem to be three bad options for me:
In any case, I should better document the exception handling. I've opened #474 for that. |
Prevents assumptions about `event` being a string. Fixes #473
Prevents assumptions about `event` being a string. Fixes #473
I think I've found a compromise that shouldn't have a measurable performance impact in #475 – can you two please check if it fixes your problems? Thank you. |
Hello @hynek Many thanks for your prompt & thorough feedback. I'll come back to you with an answer today. All the best |
Apologies for the terse issue submission and thanks for the detailed response. You are correct that this is from call sites that pass the exception object in directly. #475 looks like it will handle that now as per the test case. |
Hello both, Indeed it does. Many thanks again. |
sample stack https://gist.github.com/alangenfeld/2bc3f1d22e81af428fa487320fc6c797
The text was updated successfully, but these errors were encountered: