Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Update README.md #354

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Update README.md #354

merged 1 commit into from
Sep 28, 2020

Conversation

sk97kang
Copy link
Contributor

Description

Fix different version

Related Issues

x

Tests

x

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test or yarn test -u if you need to update snapshot.
  • Run yarn lint
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   82.78%   82.78%           
=======================================
  Files          37       37           
  Lines        1226     1226           
  Branches      372      372           
=======================================
  Hits         1015     1015           
  Misses         91       91           
  Partials      120      120           

| styled-components | >=4.4.0 |
| ----------------- | ------- |
| react | >=16.13 |
| react-native | >=0.62 |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not work at react-native 0.61?

|-------------------|---------|
| react | >=16.9 |
| react-native | >=0.58 |
| styled-components | >=4.4.0 |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be better to update to >= 5.0.0

@hyochan hyochan merged commit 87c37dc into hyochan:master Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants