Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

Release 0.0.22 #356

Merged
merged 6 commits into from
Oct 2, 2020
Merged

Release 0.0.22 #356

merged 6 commits into from
Oct 2, 2020

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Oct 2, 2020

Description

Fixes import bug on [Checkbox]. Move [PinchZoom] and [DatePicker] to packages.

Reorganize assets for main and packages. For packages, it should go inside its root while main direct to __assets in the same dir.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test or yarn test -u if you need to update snapshot.
  • Run yarn lint
  • I am willing to follow-up on review comments in a timely manner.

@hyochan
Copy link
Owner Author

hyochan commented Oct 2, 2020

@JongtaekChoi Please note that the [PinchZoom] is moved to packages.

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #356 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   77.16%   77.08%   -0.08%     
==========================================
  Files          37       37              
  Lines        1226     1222       -4     
  Branches      372      372              
==========================================
- Hits          946      942       -4     
  Misses        167      167              
  Partials      113      113              

@hyochan hyochan merged commit 910431a into master Oct 2, 2020
@hyochan hyochan deleted the release/0.0.22 branch October 2, 2020 15:07
@JongtaekChoi
Copy link
Collaborator

JongtaekChoi commented Oct 3, 2020

I didn't understand yet. Could you explain to me why it is needed to move [PinchZoom] to the packages directory?

@hyochan
Copy link
Owner Author

hyochan commented Oct 3, 2020

@JongtaekChoi Something that is bit complex to use or been an experimental including UI heavy components are currently moved to packages. We'll consider moving to main when we think they are production-ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants