feat: add bitrate to ios and audio channels to android #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyochan
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
lol who is this?
Thanks a lot for this.
For additional context, I am waiting for android subscription tutorial for turbo module for the future maintenance.
I could find an article for iOS but not in android 🤔 I can't only work on iOS side here 😅
I'll release this PR soon!
hyochan
added
🍗 enhancement
|
Thank you 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bitRateto iOS (default: 128000, same as Android)audioChannelsto Android (default: 2, same as iOS)