Reset MediaPlayer on Stop and Completion in Android

[efstathiosntonas]

No description provided.

[hyochan]

@efstathiosntonas Thank you for your contribution to this! Could you kindly explain the result of having reset after stop?

[efstathiosntonas]

@hyochan I've looked into other Android projects on GitHub that utilized MediaPlayer and most of them reset the player.

Besides that, here is a part from the docs:

There is a subtle but important difference between a newly constructed MediaPlayer object and the MediaPlayer object after reset() is called. It is a programming error to invoke methods such as getCurrentPosition(), getDuration(), getVideoHeight(), getVideoWidth(), setAudioAttributes(android.media.AudioAttributes), setLooping(boolean), setVolume(float, float), pause(), start(), stop(), seekTo(long, int), prepare() or prepareAsync() in the Idle state for both cases. If any of these methods is called right after a MediaPlayer object is constructed, the user supplied callback method OnErrorListener.onError() won't be called by the internal player engine and the object state remains unchanged; but if these methods are called right after reset(), the user supplied callback method OnErrorListener.onError() will be invoked by the internal player engine and the object will be transfered to the Error state

[hyochan]

Here's ChatGPT's response to this. According to it, we can skip it. However, considering that in this module, the mediaPlayer is reused in every scenario, I think it would be a good idea to include reset in each step.

LGTM!

[efstathiosntonas]

perfect! thanks @hyochan