Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional removeClippedSubviews #30

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Apr 2, 2022

Description

removeClippedSubviews was always set to false. Make this changeable.

Related Issues

Resolve #27

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #30 (129b62b) into master (058642f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           33        34    +1     
  Branches        12        13    +1     
=========================================
+ Hits            33        34    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 058642f...129b62b. Read the comment docs.

@hyochan hyochan merged commit adb81fe into master Apr 2, 2022
@hyochan hyochan deleted the enh/RemoveClippedSubviews branch April 2, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoveClippedSubviews support
1 participant