Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyExtractor placed on parent view #33

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Conversation

hyochan
Copy link
Owner

@hyochan hyochan commented Apr 2, 2022

Description

In 1.2.0 and 1.2.1, the keyExtractor was placed in the wrong view. Place this to correct child view.

Sorry for inconvenience 馃檹

Related Issues

#10

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

This should be handling the child view
@hyochan hyochan added the 馃洜 bugfix All kinds of bug fixes label Apr 2, 2022
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #33 (4fe59f4) into main (7229a50) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           36        36           
  Branches        13        13           
=========================================
  Hits            36        36           
Flag Coverage 螖
unittests 100.00% <100.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
index.tsx 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7229a50...4fe59f4. Read the comment docs.

@hyochan hyochan merged commit 75d14bb into main Apr 2, 2022
@hyochan hyochan deleted the bugfix/keyExtractor branch April 2, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃洜 bugfix All kinds of bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant