Fix for onEndReached not getting called #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyochan
added
🍗 enhancement
hyochan
added a commit
to hyochan/reanimated-masonry-list
that referenced
this pull request
Oct 10, 2022
4 tasks
hyochan
added a commit
to hyochan/reanimated-masonry-list
that referenced
this pull request
Oct 10, 2022
* chore: create LICENSE * feat: avoid two taps requirement for android * feat: add optional refreshControl Improvements from hyochan/react-native-masonry-list#39 * chore: vscode settings.json * fix: onEndReached not getting called Improvements in hyochan/react-native-masonry-list#46 * build: update pkgs and fix typings * fix: linting in example
|
which version is it?? |
|
@hyochan onEndReached is not called at all in any condition. Please check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on fixing onEndReached not getting called. The reason why it sometimes doesn't get called is because of this particular line
layoutMeasurement.height + contentOffset.y >= contentSize.height - paddingToBottomWhere both sides sometimes evaluate to a 6 decimal place number and because of three different measurements (height,offset, total height), comparing them introduces inaccuracy. For example if the 6th decimal point is 0 on left hand side and its 1 on right hand side. Then even if we are at the end, this function will not get called because the fore mentioned line will evaluate to false. To fix this, I have removed the decimal points from the left hand side by using Math.Ceil. This will call the function by removing uncertainties of the decimal points.
Related Issues
N/A
Tests
N/A
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn lint && yarn tscyarn testoryarn test -uif you need to update snapshot.