Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed setting ctrlKey since it's read-only #62

Merged
merged 2 commits into from Sep 25, 2017
Merged

removed setting ctrlKey since it's read-only #62

merged 2 commits into from Sep 25, 2017

Conversation

joshuagish
Copy link
Contributor

event.ctrlKey is read-only which causes errors in the console when we try to set it

see https://www.w3schools.com/jsref/event_ctrlkey.asp

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 87.898% when pulling 6dc564b on thecitywelivein:master into 91c184a on hyojin:master.

@hyojin
Copy link
Owner

hyojin commented Sep 20, 2017

@thecitywelivein Hi, thanks for your PR. Yes, it's read-only. but it's the way to handle multiple selection in material-ui internally now. Probably it will be disappeared on v1.
By the way, I couldn't get errors on latest chrome and FF. which browsers throw that error?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 87.975% when pulling 5b38d9e on thecitywelivein:master into 91c184a on hyojin:master.

@joshuagish
Copy link
Contributor Author

Looks like typescript is causing the error to be shown. Wrapping it in a try/catch prevents errors for me. I've updated the PR

This is the error
screen shot 2017-09-22 at 3 27 15 pm

@hyojin hyojin merged commit 7c41160 into hyojin:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants