instance openings for ifc

[anthonie-kramer]

BACKGROUND:

• What led to this work, and what is the broader context of this change?
• Openings were not being created for ElementInstance objects
• Openings were not being transformed for their LocalTransform

DESCRIPTION:

• What does this PR specifically accomplish?
• Adds correct transform and creates openings that can be used for the IFCRELVOIDSELEMENT creation

TESTING:

• How should a reviewer observe the behavior desired by this pull request?
• I have added a test that uses instances and creates the openings sucessfully

FUTURE WORK:

• Is there any future work needed or anticipated? Does this PR create any obvious technical debt?
• We should refactor Elements to find a better way to include Openings in a more straightforward way

REQUIRED:

• All changes are up to date in CHANGELOG.md.

COMMENTS:

• Any other notes.

---

This change is 

[anthonie-kramer]

Updated with master, and resolved merge conflicts (updated with your ZAxis extrusion fix). So should be good for review!

Reviewable status: 0 of 1 approvals obtained (waiting on @katehryhorenko)

[katehryhorenko]

LGTM, just one small comment about naming

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @anthonie-kramer)

---

Elements.Serialization.IFC/src/Serialization/IFC/IFCElementExtensions.cs line 44 at r1 (raw file):

                    for (int i = 0; i < geoElementWithOpenings.Openings.Count; i++)
                    {
                        Opening o = geoElementWithOpenings.Openings[i];

Just a small preference here. Could you avoid names like 'o'? It's more readable, when the variable name is more meaningful, like 'opening'

[anthonie-kramer]

Done!

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @katehryhorenko)

---

Elements.Serialization.IFC/src/Serialization/IFC/IFCElementExtensions.cs line 44 at r1 (raw file):

Previously, katehryhorenko (Kateryna Hryhorenko) wrote…

Just a small preference here. Could you avoid names like 'o'? It's more readable, when the variable name is more meaningful, like 'opening'

great point, fixed!