Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GeometrisElement.Intersection method #1042

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix: GeometrisElement.Intersection method #1042

merged 1 commit into from
Oct 24, 2023

Conversation

katehryhorenko
Copy link
Contributor

@katehryhorenko katehryhorenko commented Oct 24, 2023

BACKGROUND:
I changed the GeometricElement.Intersection method to support RepresentationInstances. I playing with Stocking Plan Exporter and noticed that sometimes pdf contains wrong geometry:
image

DESCRIPTION:

  • The issue was that I have changed prev. this method to collect intersection points and only after that add them to the graph. And for the case below it doesn't work:
    image

I changed method to add points like it was before

TESTING:
image

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Change log contains data that Intersection method was changed

This change is Reviewable

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@katehryhorenko katehryhorenko merged commit 12b323e into master Oct 24, 2023
2 checks passed
@katehryhorenko katehryhorenko deleted the Fixes branch October 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants