Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add todo #883

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Add todo #883

merged 3 commits into from
Apr 19, 2023

Conversation

wynged
Copy link
Member

@wynged wynged commented Sep 7, 2022 •
edited by andrewheumann

BACKGROUND:

  • While exploring a gltf regression we attempted to use a test library but it isn't available until .NET 6.

DESCRIPTION:

  • Add a note about a using gltf validation library when we migrate to .NET 6.

TESTING:

  • N/A

FUTURE WORK:

  • N/A

REQUIRED:

  • [ ] All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

@wynged wynged requested a review from ikeough September 7, 2022 13:58
@ikeough
Copy link
Contributor

ikeough commented Nov 17, 2022

@wynged What's happening with this PR?

@wynged
Copy link
Member Author

wynged commented Nov 18, 2022

Last we talked about this we were bummed we couldn't use this library and wanted to add the to-do. I think I added you as a reviewer.

wynged
wynged commented Nov 29, 2022
View reviewed changes
Copy link
Member Author

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like me to merge this or close the PR? no reason to keep it floating around. @ikeough

Reviewable status: 0 of 1 approvals obtained (waiting on @ikeough)

ikeough
ikeough approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@ikeough ikeough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@ikeough ikeough merged commit e677333 into master Apr 19, 2023
@ikeough ikeough deleted the add-todo branch April 19, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeough ikeough ikeough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wynged @ikeough