-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dmuravskyi/routing warnings #918
Dmuravskyi/routing warnings #918
Conversation
…uld go beneath other part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @DmytroMuravskyi)
Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs
line 682 at r1 (raw file):
if (excluded != null && excluded.Contains(id)) { MarkExpeniseRoute(pq, travelCost, path, id, u, bestCost);
spelling. maybe you're trying to mark the "Expensive" route?
Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs
line 722 at r1 (raw file):
} var rigthCost = NOT_CONNECTED;
spelling rigth => right
1e92114
to
3a02159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @wynged)
Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs
line 682 at r1 (raw file):
Previously, wynged (Eric Wassail) wrote…
spelling. maybe you're trying to mark the "Expensive" route?
Done.
Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs
line 722 at r1 (raw file):
Previously, wynged (Eric Wassail) wrote…
spelling rigth => right
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! 1 of 1 approvals obtained
BACKGROUND:
DESCRIPTION:
TESTING:
REQUIRED:
CHANGELOG.md
.COMMENTS:
This change is