Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmuravskyi/routing warnings #918

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

DmytroMuravskyi
Copy link
Contributor

@DmytroMuravskyi DmytroMuravskyi commented Nov 10, 2022

BACKGROUND:

  • When AdaptiveGraphRouting fail in just throw exception about "0 key is not found". It's not informative enough.

DESCRIPTION:

  • Added ErrorMessages list to ErrorMessages with exact inputs that failed and reason: it either not connected or route doesn't meet all criteria. Possible reasons are mentioned in the message.

TESTING:

  • Added AdaptiveGraphRoutingWarinigs test

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Fix Obstacle.FromLine if line is vertical and start is higher than end

This change is Reviewable

@wynged wynged self-requested a review November 10, 2022 15:05
Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @DmytroMuravskyi)


Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 682 at r1 (raw file):

                    if (excluded != null && excluded.Contains(id))
                    {
                        MarkExpeniseRoute(pq, travelCost, path, id, u, bestCost);

spelling. maybe you're trying to mark the "Expensive" route?


Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 722 at r1 (raw file):

                        }

                        var rigthCost = NOT_CONNECTED;

spelling rigth => right

Copy link
Contributor Author

@DmytroMuravskyi DmytroMuravskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @wynged)


Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 682 at r1 (raw file):

Previously, wynged (Eric Wassail) wrote…

spelling. maybe you're trying to mark the "Expensive" route?

Done.


Elements/src/Spatial/AdaptiveGrid/AdaptiveGraphRouting.cs line 722 at r1 (raw file):

Previously, wynged (Eric Wassail) wrote…

spelling rigth => right

Done.

Copy link
Member

@wynged wynged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit ea629a7 into hypar-io:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants